[ovs-dev] [PATCH 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

Jarno Rajahalme jrajahalme at nicira.com
Mon May 18 23:15:32 UTC 2015


> On May 15, 2015, at 11:01 AM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> 
> 
>> On May 15, 2015, at 10:03 AM, Romain Lenglet <romain.lenglet at oracle.com <mailto:romain.lenglet at oracle.com>> wrote:
>> 
>> On May 15, 2015 at 7:45:31 AM, Jarno Rajahalme (jrajahalme at nicira.com <mailto:jrajahalme at nicira.com>(mailto:jrajahalme at nicira.com <mailto:jrajahalme at nicira.com>)) wrote:
>> 
>>> 
>>>> On May 14, 2015, at 23:44, Romain Lenglet wrote:
>>>> 
>>>> Thanks Jarno!
>>>> 
>>>>> On May 14, 2015 at 2:11:50 PM, Jarno Rajahalme (jrajahalme at nicira.com <mailto:jrajahalme at nicira.com>(mailto:jrajahalme at nicira.com <mailto:jrajahalme at nicira.com>)) wrote:
>>>>> The new ovs-ofctl 'bundle' command accepts files similar to
>>>>> 'add-flows', but each line can optionally start with 'add', 'modify',
>>>>> 'delete', 'modify_strict', or 'delete_strict' keyword, so that
>>>>> arbitrary flow table modifications may be specified in a single file.
>>>>> The modifications in the file are executed as a single transaction
>>>>> using a OpenFlow 1.4 bundle.
>>>> 
>>>> I would suggest a different design for the ovs-ofctl support: add a --bundle option to the ovs-ofctl’s add-flows, del-flows and replace-flows, so that all the flow mods generated by each execution would be sent in a bundle. This option would be accepted only when OF1.4 or later is used.
>>>> 
>>> 

I just posted a v2 that adds the ‘—bundle’ option that is supported for all flow mod commands, including ‘replace-flows'. With it, or with the bundle command, the OF1.4 is now implicitly assumed, so the -O OpenFlow14 option is not needed. It also skips the previously used OpenFlow barriers after each flow mod, which may make operation faster for larger modifications.

  Jarno




More information about the dev mailing list