[ovs-dev] [PATCH] ovn: Fix a northd bug.

Ben Pfaff blp at nicira.com
Tue May 19 15:31:15 UTC 2015


On Mon, May 18, 2015 at 06:58:15PM -0700, Alex Wang wrote:
> The 'chassis' member in the 'struct sbrec_binding' must always be
> non-null.  However, this is not case when creating the binding
> in "set_bindings()".  And it causes segfault while starting northd
> with existing ovnnb configuration.
> 
> This commit fixes the bug by always setting the 'chassis' to an
> empty string.
> 
> Signed-off-by: Alex Wang <alexw at nicira.com>

This may not be the best fix.  When the Binding table was introduced,
the 'chassis' column could always be populated immediately because the
chassis was what added it and thus it could always fill in its own name,
so there wasn't any point in allowing the chassis column to be empty.
But now that Binding rows are added before we have a chassis, the best
fix might be to change the schema to allow 'chassis' to be empty (and
then change any references to 'chassis' to no longer assume it must be
nonnull).

What do you think?

Thanks,

Ben.



More information about the dev mailing list