[ovs-dev] [PATCH v4 1/4] datapath-windows: Support for custom VXLAN tunnel port

[Nithin Raju]

hi Sorin,

> While I’m ok with using do-while loop as an alternative to using labels, you are using 2 do-while looks here. Does it add more clarity than using labels? :) I am ok either way.
> SV: I am not in favor of using labels. For me, it makes the code very hard to follow and maintain in the long run. Same is the case for using return in the middle of the function, where the cleanup code needs to be duplicate.

OK, sounds good. I try to be accommodative to different coding styles. But, I liked to point out when sticking to a particular coding style seemed to make the code a little less readable in some cases. That’s all.

I’ll look forward to the patches with the comments addressed.

Like I mentioned in the other email, when you send out a new revision of a series, send out all the patches. It makes it easier for review.

In the comments of the commit message, you can say “No changes compared to previous version”, if nothing changed.

thanks,
Nithin