[ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

[Andy Zhou]

Justin suggested changing to decimal. It seems reasonable to me as
well since we don't wildcard recirc_id at the moment as you have
pointed out.

In case we do wildcard recirc_id down the road, I'd lean towards your proposal.


On Wed, May 20, 2015 at 9:42 AM, Joe Stringer <joestringer at nicira.com> wrote:
> On 18 May 2015 at 18:26, Andy Zhou <azhou at nicira.com> wrote:
>> The output of 'ovs-ofctl dump-flows' command prints recirc_id in decimal
>> in action parts of the output, while prints that in hex in matching
>> parts of the same output.
>>
>> This patch fixes the inconsistency by always printing recirc_id
>> values in decimal.
>>
>> Reported-by: Justin Pettit <jpettit at nicira.com>
>> Signed-off-by: Andy Zhou <azhou at nicira.com>
>
> Ha, I noticed this yesterday and was going to propose the
> opposite-change actions to hex.
>
> The only thing with the current formatting is that if there is a mask,
> it will be printed in hex (although I don't think we wildcard
> recirc_id anyway).