[ovs-dev] [PATCH] datapath: Support masked set actions.

Jarno Rajahalme jrajahalme at nicira.com
Fri May 22 19:51:37 UTC 2015


> On May 21, 2015, at 9:23 PM, Jesse Gross <jesse at nicira.com> wrote:
> 
> On Thu, May 21, 2015 at 4:39 PM, Jarno Rajahalme <jrajahalme at nicira.com <mailto:jrajahalme at nicira.com>> wrote:
>> OVS kernel module support for masked set actions in already upstream
>> in Linux.  This patch adds the same for the OVS tree kernel module.
>> 
>> The existing set action sets many fields at once.  When only a subset
>> of the IP header fields, for example, should be modified, all the IP
>> fields need to be exact matched so that the other field values can be
>> copied to the set action.  A masked set action allows modification of
>> an arbitrary subset of the supported header bits without requiring the
>> rest to be matched.
>> 
>> Masked set action is now supported for all writeable key types, except
>> for the tunnel key.  The set tunnel action is an exception as any
>> input tunnel info is cleared before action processing starts, so there
>> is no tunnel info to mask.
>> 
>> The kernel module converts all (non-tunnel) set actions to masked set
>> actions.  This makes action processing more uniform, and results in
>> less branching and duplicating the action processing code.  When
>> returning actions to userspace, the conversion is inverted.  We use a
>> kernel internal action code to be able to tell the userspace provided
>> and converted masked set actions apart.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Can you also add the upstream commit ID to the change log? (it's
> 83d2b9ba1abca241df44a502b6da950a25856b5b).
> 

Done.

> Otherwise, this looks basically the same as the upstream patch and I
> nothing that should require special backporting comes to mind, so
> looks good to me.
> 

Yeah, I diffed this patch against the one applied upstream and there is no difference in the code.
The only thing that took any thought was the ordering of userspace-only and kernel-only actions in the header.

> Acked-by: Jesse Gross <jesse at nicira.com <mailto:jesse at nicira.com>>

Thanks for the re-review, pushed to master!

  Jarno




More information about the dev mailing list