[ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port
Nithin Raju
nithin at vmware.com
Tue May 26 06:50:31 UTC 2015
hi Sorin,
This patch looks much better. Like I mentioned the review to the previous revision, a duplicate vport delete request for the same VXLAN port can mess things up, including accessing a freed up ‘vport’ structure. But, that is a corner case, and we can address it later.
I just found a new issue in OvsTunnelVportPendingUninit() where you are not taking the vport lock (switchContext->dispatchLock). Looks good otherwise.
> +static VOID
> +OvsTunnelVportPendingUninit(PVOID context,
> + NTSTATUS status,
> + UINT32 *replyLen)
You are not taking the switchContext->dispatchLock while deleting from the hash tables.
I should be able to ACK the next revision.
thanks,
-- Nithin
More information about the dev
mailing list