[ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

[Flavio Leitner]

On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote:
> On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote:
> > OVS interface for generic networking device operation looks odd. have
> > you considered adding new device ioctl to do this?
> 
> New ioctls for networking configuration are generally not allowed. The
> preferred way to configure networking is netlink. And as this is very
> much ovs specific (all other users of dev_disable_lro such as bridging
> want to do this unconditionally), ovs netlink is the correct place to
> put this to.

Exactly. Team, Bonding, bridge, and when you enable forwarding on a
networking device gets LRO automatically disabled in the kernel.

I suggest to always disable LRO in the kernel as the other examples
do until there is a real need in OVS to benefit from LRO to implement
such API change.

fbl