[ovs-dev] [PATCH] datapath: do not add vlan_hwaccel_push_inside() for kernel >= 3.18.13

Hauke Mehrtens hauke at hauke-m.de
Wed May 27 21:07:17 UTC 2015


On 05/27/2015 10:14 PM, Jesse Gross wrote:
> On Tue, May 26, 2015 at 4:59 PM, Ben Pfaff <blp at nicira.com> wrote:
>> diff --git a/datapath/linux/compat/include/linux/if_vlan.h b/datapath/linux/compat/include/linux/if_vlan.h
>> index 05c2876..0750bbe 100644
>> --- a/datapath/linux/compat/include/linux/if_vlan.h
>> +++ b/datapath/linux/compat/include/linux/if_vlan.h
>> @@ -52,7 +52,7 @@ static inline struct sk_buff *rpl_vlan_insert_tag_set_proto(struct sk_buff *skb,
>>  }
>>  #endif
>>
>> -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0)
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,18,13)
> 
> I think it's probably better to use a configure check here. Given that
> this was already backported to -stable, it seems like there is a
> pretty high probability that it could show up in earlier kernels too.
> 

Thanks Ben for posting this on the mailing list, I did not know the
correct processes, I just saw the problem in OpenWrt and wanted this to
be fixed upstream too.

This change was only backported to kernel 3.18 and to no other stable
kernel, I do not think it will show up in any other stable mainline kernel.

Hauke



More information about the dev mailing list