[ovs-dev] [PATCH 4/4] odp-util: Geneve netlink decoding.

[Joe Stringer]

On 28 May 2015 at 18:39, Jesse Gross <jesse at nicira.com> wrote:
> On Wed, May 27, 2015 at 3:18 PM, Andy Zhou <azhou at nicira.com> wrote:
>> On Wed, May 27, 2015 at 10:48 AM, Jesse Gross <jesse at nicira.com> wrote:
>>> Even though userspace does not yet support Geneve options,
>>> the kernel does and there is some basic support for decoding
>>> those attributes. This adds the ability to print Geneve
>>> attributes that might potentially come from the kernel.
>>>
>>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>>> ---
>>
>> git am says:
>>
>> Applying: odp-util: Geneve netlink decoding.
>> /home/azhou/projs/ovs-review/ovs/.git/rebase-apply/patch:50: trailing
>> whitespace.
>>     if (mask && nl_attr_get_size(attr) != nl_attr_get_size(mask_attr)) {
>> warning: 1 line adds whitespace errors.
>>
>> Assume this will be fixed: Acked-by: Andy Zhou <azhou at nicira.com>
>
> Thanks for the reviews. I pushed this series to master with the
> changes mentioned.

Clang complains about cast alignment:
https://travis-ci.org/openvswitch/ovs/jobs/64510105

lib/odp-util.c:2936:30: error: cast from 'uint8_t *' (aka 'unsigned char *') to

      'struct geneve_opt *' increases required alignment from 1 to 2

      [-Werror,-Wcast-align]

    struct geneve_opt *opt = (struct geneve_opt *)key->d;

                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~

lib/odp-util.c:2937:35: error: cast from 'uint8_t *' (aka 'unsigned char *') to

      'struct geneve_opt *' increases required alignment from 1 to 2

      [-Werror,-Wcast-align]

    struct geneve_opt *opt_mask = (struct geneve_opt *)(mask ? mask->d : NULL);