[ovs-dev] [PATCH ovn] controller: Drop unknown datapath log message.
Ben Pfaff
blp at nicira.com
Fri May 29 17:30:59 UTC 2015
On Thu, May 28, 2015 at 04:37:14PM -0400, Russell Bryant wrote:
> This patch emits a log message that is encountered a lot under normal
> circumstances. For example, I'm seeing it almost 20,000 times in a
> test run of the OpenStack test suite and hundreds of times while doing
> basic tasting under ovs-sandbox.
>
> ovn-controller keeps a hash of logical data paths that have ports
> associated with them (logical_datapaths). This message occurs when
> looping through all Pipeline entries and a Pipeline's logical datapath
> does not exist in this hash. However, a logical switch with no ports
> will have entries in the Pipeline table, but nothing in Bindings (and
> not end up in the logical_datapaths hash). Currently, this message
> will be emitted 6 times for every logical switch without any logical
> ports every time the ovn-controller main loop comes around and runs
> this code. Instead, the right thing to do to silently ignore the
> pipeline entry, because there's nothing useful to be done with it.
>
> Signed-off-by: Russell Bryant <rbryant at redhat.com>
Applied, thanks!
More information about the dev
mailing list