[ovs-dev] [RFC PATCH 03/13] tunneling: add ipv6 fields to netdev_tunnel_config

Ben Pfaff blp at nicira.com
Fri May 29 21:29:50 UTC 2015


On Thu, May 14, 2015 at 08:12:34PM +0200, Jiri Benc wrote:
> Allow configuration of ipv6 tunnel endpoints.
> 
> Signed-off-by: Jiri Benc <jbenc at redhat.com>

The OVS coding style, for better or worse, calls for {} to be used even
when there's only a single statement, so there are some missing {} in
parse_tunnel_ip().

Now that I see its use, I think I would rather see smap_add_ipv6() as a
helper within netdev-vport.c, because I don't expect it to see wide use
outside of that file.

Documentation for the new tunnel support is missing from
vswitch/vswitch.xml and it is not yet mentioned in NEWS (perhaps those
are in an upcoming patch)?

Thanks,

Ben.



More information about the dev mailing list