[ovs-dev] [PATCH 2/3] ofproto-dpif: Refactor feature support structure.

[Joe Stringer]

On 29 May 2015 at 13:24, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Apr 13, 2015 at 05:56:16PM -0700, Joe Stringer wrote:
>> Place all of the detected datapath features into a separate structure,
>> initialized when the dpif_backer is opened and shared with xbridges.
>>
>> Signed-off-by: Joe Stringer <joestringer at nicira.com>
>
> It would be nice not to lose the detailed comments in struct xbridge as
> the members get carried over into the new structure.
>
> Acked-by: Ben Pfaff <blp at nicira.com>

I thought a bunch of it was redundant, but looking back the additional
context could be useful. I rolled in the following incremental and
applied to master:

diff --git a/ofproto/ofproto-dpif.h b/ofproto/ofproto-dpif.h
index f9f62ab..9d625a1 100644
--- a/ofproto/ofproto-dpif.h
+++ b/ofproto/ofproto-dpif.h
@@ -84,10 +84,17 @@ struct dpif_backer_support {
      * in a match */
     size_t max_mpls_depth;

-    /* True if the datapath supports the corresponding feature. */
+    /* True if the datapath supports masked data in OVS_ACTION_ATTR_SET
+     * actions. */
     bool masked_set_action;
+
+    /* True if the datapath supports recirculation. */
     bool recirc;
+
+    /* True if the datapath supports tnl_push and pop actions. */
     bool tnl_push_pop;
+
+    /* True if the datapath supports OVS_FLOW_ATTR_UFID. */
     bool ufid;
 };