[ovs-dev] [ovsdb speedup v3 03/19] jsonrpc-server: make setting mt->select into its own functions

Andy Zhou azhou at nicira.com
Sat May 30 00:02:36 UTC 2015


On Fri, May 29, 2015 at 11:03 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Apr 09, 2015 at 06:40:12PM -0700, Andy Zhou wrote:
>> To make ovsdb_monitor an opaque to ovsdb_jsonrpc server object.
>>
>> Signed-off-by: Andy Zhou <azhou at nicira.com>
>> Acked-by: Ben Pfaff <blp at nicira.com>
>
> I think that the change from |= to = in this commit is going to break
> some corner cases where different columns within a table have different
> monitoring requirements.  I'd change ovsdb_monitor_set_select() to use
> |=, and perhaps rename it to reflect that change
> |(ovsdb_monitor_add_select()?).

Fixed, I have also update the logic in the following patches.
>
> Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list