[ovs-dev] [PATCH] dpctl: Fix jump through wild pointer in "dpctl/help".

Ben Pfaff blp at nicira.com
Wed Nov 4 01:41:46 UTC 2015


On Tue, Oct 20, 2015 at 10:55:37PM +0000, Daniele Di Proietto wrote:
> 
> On 17/10/2015 14:24, "Ben Pfaff" <blp at nicira.com> wrote:
> 
> >dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure
> >it passed to the handler, which meant that dpctl_help() could see a
> >nonnull
> >(indeterminate) 'usage' pointer and jump through it, causes a crash.
> >This commit fixes the crash by fully initializing the structure.
> >
> >The dpctl/help command wasn't going to do anything useful anyway, so this
> >commit also stops registering it.
> >
> >Reported-by: Murali R <muralirdev at gmail.com>
> >Reported-at: 
> >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_piperm
> >ail_discuss_2015-2DOctober_019135.html&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJA
> >XVeAw-YihVMNtXt-uEs&r=SmB5nZacmXNq0gKCC1s_Cw5yUNjxgD4v5kJqZ2uWLlE&m=OrWGS3
> >tQ3PzCvpaif3pjUIuOxAY8nQCTY_8Q_Qs_Wj8&s=TeEaw1_lnbTmgin2fd7Sjw0dEf__XAROJU
> >z7KORhS1s&e= 
> >Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

Thanks Daniele, I applied this to master and branch-2.4.



More information about the dev mailing list