[ovs-dev] [PATCH v3] datapath: Add support for lwtunnel

[Pravin Shelar]

On Mon, Nov 2, 2015 at 11:07 PM, Joe Stringer <joestringer at nicira.com> wrote:
> On 31 October 2015 at 04:30, Pravin B Shelar <pshelar at nicira.com> wrote:
>> Following patch adds support for lwtunnel to OVS datapath.
>> With this change OVS datapath detect lwtunnel support and
>> make use of new APIs if available. On older kernel where the
>> support is not there the backported tunnel modules are used.
>> These backported tunnel devices acts as lwtunnel devices.
>> I tried to keep backported module same as upstream for easier
>> bug-fix backport. Since STT and LISP are not upstream OVS
>> always needs to use respective modules from tunnel compat layer.
>> To make it work on kernel 4.3 I have converted STT and LISP
>> modules to lwtunnel API model.
>>
>> lwtunnel make use of skb-dst to pass tunnel information to the
>> tunnel module. On older kernel this is not possible. So the
>> metadata ref is stored in OVS_CB. Direct call to tunnel transmit
>> function is made by respective tunnel vport modules. Similarly
>> on receive side tunnel recv directly call netdev-vport-receive
>> to pass the skb to OVS.
>>
>> Major backported components include:
>> Geneve, GRE, VXLAN, ip_tunnel, udp-tunnels GRO.
>>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> I downloaded this latest version + the travis patches, and still had a
> couple of issues:
>
> https://travis-ci.org/joestringer/openvswitch/builds/88822811
>
> Easily fixed though:
> https://github.com/joestringer/openvswitch/compare/review/lwtunnel_v3...dev/lwtunnel
> https://travis-ci.org/joestringer/openvswitch/builds/88834616
>

Thanks for the fixes, I have posted comments on the commits on github.