[ovs-dev] [mointor2 7/9] ovsdb-client: support monitor2

Andy Zhou azhou at nicira.com
Tue Nov 24 10:14:35 UTC 2015


On Tue, Nov 10, 2015 at 9:34 AM, Ben Pfaff <blp at ovn.org> wrote:
> On Wed, Oct 21, 2015 at 09:45:29PM -0700, Andy Zhou wrote:
>> Add monito2 option to ovsdb-client. Sed ovsdb-client(1) manpage patch
>
> s/monito2/monitor2/
>
>> for details.
>>
>> Signed-off-by: Andy Zhou <azhou at nicira.com>
>
> I have a few minor suggestions, see below.
>
> Acked-by: Ben Pfaff <blp at ovn.org>
Thanks for the review. Fixed the typo and style issue In V2.
>
> diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in
> index 422f6e1..baccf33 100644
> --- a/ovsdb/ovsdb-client.1.in
> +++ b/ovsdb/ovsdb-client.1.in
> @@ -133,7 +133,7 @@ each group.  Whether multiple groups or only a single group is
>  specified, any given column may only be mentioned once on the command
>  line.
>  .IP
> -If \fB\-\-detach\fR is used with \fBmonitor\fR or \fBmointor2\fR, then
> +If \fB\-\-detach\fR is used with \fBmonitor\fR or \fBmonitor2\fR, then
>  \fBovsdb\-client\fR detaches after it has successfully received and
>  printed the initial contents of \fItable\fR.
>  .IP
> diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
> index c747375..f279d3b 100644
> --- a/ovsdb/ovsdb-client.c
> +++ b/ovsdb/ovsdb-client.c
> @@ -973,10 +973,10 @@ do_monitor__(struct jsonrpc *rpc, const char *database,
>              } else if (msg->type == JSONRPC_REPLY
>                         && json_equal(msg->id, request_id)) {
>                  switch(version) {
> -                case OVSDB_MONITOR_V1 :
> +                case OVSDB_MONITOR_V1:
>                      monitor_print(msg->result, mts, n_mts, true);
>                      break;
> -                case OVSDB_MONITOR_V2 :
> +                case OVSDB_MONITOR_V2:
>                      monitor2_print(msg->result, mts, n_mts);
>                      break;
>                  case OVSDB_MONITOR_VERSION_MAX:



More information about the dev mailing list