[ovs-dev] [PATCH v2 00/11] Conntrack debugging appctl/dpctl

Joe Stringer joe at ovn.org
Tue Nov 24 18:22:36 UTC 2015


On 24 November 2015 at 10:20, Daniele Di Proietto
<diproiettod at vmware.com> wrote:
>
> On 24/11/2015 10:01, "Ben Pfaff" <blp at ovn.org> wrote:
>
>>On Thu, Nov 05, 2015 at 07:12:31PM -0800, Daniele Di Proietto wrote:
>>> The goal of this series is to introduce two dpctl command to interact
>>> with the Linux kernel connection tracker.  The same infrastructure
>>> will be used by the userspace connection tracker.
>>>
>>> First, it defines some structures and some formatting routines
>>>(ct-dpif).
>>>
>>> Then, it adds some code to transform the netlink conntrack format
>>> into the OVS specific structure (netlink-conntrack)
>>>
>>> Some function pointers are added into dpif-provider to implement
>>>conntrack
>>> flushing and dumping.
>>>
>>> dpif-netlink implements the new dpif-provider interface using
>>> netlink-conntrack.
>>>
>>> New functions are added in ct-dpif to implement dumping and flushing.
>>>
>>> The dpctl commands are finally added to the dpctl module, and they're
>>> used by the system testsuite.
>>>
>>> Finally, a test module (test-netlink-conntrack) is added to allow the
>>>use
>>> of the netlink-conntrack API without a datapath.
>>
>>Who do you think should review this series?  Joe, I see that you started
>>in on it; do you plan to review the whole thing?
>
> Joe offered to review the series, but before that happens:
>
> - We wanted to merge more system tests that have been posted to the
>   mailing list (I'll review them today)
> - I need to address Joe's comments
> - I'll rebase (against the new system tests) and repost

Thanks for the update Daniele. I'm mainly focused on other things at
the moment but I'll try to be more prompt with the next round of
review.



More information about the dev mailing list