[ovs-dev] [PATCH] datapath-windows: fix MIN() macro
Russell Bryant
russell at ovn.org
Wed Nov 25 20:07:02 UTC 2015
On 11/25/2015 03:02 PM, Nithin Raju wrote:
> Signed-off-by: Nithin Raju <nithin at vmware.com>
> ---
> datapath-windows/ovsext/Util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h
> index 0bbc52b..e5ba72b 100644
> --- a/datapath-windows/ovsext/Util.h
> +++ b/datapath-windows/ovsext/Util.h
> @@ -66,7 +66,7 @@ VOID OvsFreeAlignedMemory(VOID *ptr);
> VOID OvsAppendList(PLIST_ENTRY dst, PLIST_ENTRY src);
>
>
> -#define MIN(_a, _b) (_a) > (_b) ? (_b) : (_a)
> +#define MIN(_a, _b) ((_a) > (_b) ? (_b) : (_a))
> #define ARRAY_SIZE(_x) ((sizeof(_x))/sizeof (_x)[0])
> #define OVS_SWITCH_PORT_ID_INVALID (NDIS_SWITCH_PORT_ID)(-1)
>
>
Acked-by: Russell Bryant <russell at ovn.org>
I think the commit message could be a bit better though. It doesn't say
anything about what was wrong, though the patch is obvious and trivial
enough.
--
Russell Bryant
More information about the dev
mailing list