[ovs-dev] [PATCH v1] Ipfix: Skip BFD control packet

[Ben Pfaff]

On Wed, Nov 25, 2015 at 02:32:46AM -0800, Wenyu Zhang wrote:
> This patch is to skip BFD control packets in ipfix.
> BFD control packet should be tunnel packet with 0 tunnel id,
> and the inner packet is UDP packet with destination port 3784.
> 
> Signed-off-by: Wenyu Zhang <wenyuz at vmware.com>

I can't see how this could work correctly, since there's a missing
htons() on BFD_CONTROL_DEST_PORT, as reported by "sparse":

    ../ofproto/ofproto-dpif-ipfix.c:1721:13: warning: restricted ovs_be16 degrades to integer

I don't see any rationale anywhere.