[ovs-dev] [PATCH] ofp-util: Add "check_overlap" and "reset_counts" to stateful flags.

[Simon Horman]

On Sat, Nov 28, 2015 at 11:56:46AM -0800, Ben Pfaff wrote:
> On Wed, Nov 25, 2015 at 04:57:02PM +0900, Simon Horman wrote:
> > On Wed, Nov 25, 2015 at 04:22:28PM +0900, Simon Horman wrote:
> > > On Tue, Sep 29, 2015 at 11:50:40AM -0700, Ben Pfaff wrote:
> > > > The OpenFlow specification implies that every flag is part of the flow
> > > > state, even though that isn't really meaningful for OFPFF_CHECK_OVERLAP
> > > > or OFPFF_RESET_COUNTS.  This commit adds them to the flow state (reported
> > > > in flow stats replies).
> > > > 
> > > > Found by OFTest.
> > > > 
> > > > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > > 
> > > Well that is the silliest thing I have seen all day.
> > > Do you know of any plan to resolve this in future Open Flow versions?
> > > 
> > > Reviewed-by: Simon Horman <simon.horman at netronome.com>
> > 
> > Oops, I spoke slightly to soon.
> > 
> > I think the test you add is slightly misleading as it seems to me
> > that flags have been exposed since OF1.3 rather than OF1.4.
> > 
> > The following incremental change to that test, though verbose,
> > illustrates that.
> 
> Simon, thank you.
> 
> I feel like this makes you a co-author, are you willing to give me a
> Signed-off-by for it?

Sure, here it is:

Signed-off-by: Simon Horman <simon.horman at netronome.com>