[ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

Andy Zhou azhou at nicira.com
Thu Oct 1 18:48:21 UTC 2015


Thanks for the fix. I have libcap-ng installed on my system and forgot
to test compiling without it. Sorry.


On Thu, Oct 1, 2015 at 8:52 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Oct 01, 2015 at 11:29:16AM -0400, Russell Bryant wrote:
>> The function daemon_become_new_user_linux was conditionally defined but
>> then used in code unconditionally.  If HAVE_LIBCAPNG is not defined, the
>> function would never be called, but it still must exist.
>> Adjust the #if guard around the function to be around the body of the
>> function instead of outside of its definition to ensure the function is
>> always defined, even if empty.
>> This issue was introduced in e91b927d8966bfcb9768225392324dde4fd7d7f6.
>> Signed-off-by: Russell Bryant <rbryant at redhat.com>
> Applied, thanks!

More information about the dev mailing list