[ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

Russell Bryant rbryant at redhat.com
Thu Oct 1 19:41:56 UTC 2015


Andy, no problem!  It was an easy fix.  That's the life of working
against master.  :-)

I'm going to look into updating the RPM spec file for the new
dependency, as well.

-- 
Russell Bryant

On 10/01/2015 02:48 PM, Andy Zhou wrote:
> Russell,
> 
> Thanks for the fix. I have libcap-ng installed on my system and forgot
> to test compiling without it. Sorry.
> 
> andy
> 
> On Thu, Oct 1, 2015 at 8:52 AM, Ben Pfaff <blp at nicira.com> wrote:
>> On Thu, Oct 01, 2015 at 11:29:16AM -0400, Russell Bryant wrote:
>>> The function daemon_become_new_user_linux was conditionally defined but
>>> then used in code unconditionally.  If HAVE_LIBCAPNG is not defined, the
>>> function would never be called, but it still must exist.
>>>
>>> Adjust the #if guard around the function to be around the body of the
>>> function instead of outside of its definition to ensure the function is
>>> always defined, even if empty.
>>>
>>> This issue was introduced in e91b927d8966bfcb9768225392324dde4fd7d7f6.
>>>
>>> Signed-off-by: Russell Bryant <rbryant at redhat.com>
>>
>> Applied, thanks!




More information about the dev mailing list