[ovs-dev] [PATCH 4/4] ovn-ctl: Ability to upgrade databases.

Gurucharan Shetty shettyg at nicira.com
Fri Oct 2 14:07:49 UTC 2015


On Fri, Oct 2, 2015 at 6:21 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Oct 01, 2015 at 03:09:56PM -0700, Gurucharan Shetty wrote:
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> In upgrade_ovn_dbs, I'd consider upgrading both databases even if they
> don't appear in the list of databases.  It seems more robust to me,
> especially given this comment in start_northd:

Agree. This patch did have a bug for first time start which gets fixed
with your suggestion.

>
>  # We expect ovn-northd to be co-located with ovsdb-server handling both the
>  # OVN_Northbound and OVN_Southbound dbs.
>
> I'm not sure about error handling.  If an upgrade to one database fails,
> it might be better to try to upgrade the other database instead of
> exiting immediately.

Okay. Will do.

>
> Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list