[ovs-dev] [PATCH] datapath: Fix compilation on kernel 2.6.32

[Pravin Shelar]

On Fri, Oct 9, 2015 at 2:03 PM, Joe Stringer <joestringer at nicira.com> wrote:
> On 9 October 2015 at 13:21, Pravin B Shelar <pshelar at nicira.com> wrote:
>> Fixes following compilation error:
>>
>> CC [M]  /home/travis/build/openvswitch/ovs/datapath/linux/actions.o
>>
>> In file included from
>> /home/travis/build/openvswitch/ovs/datapath/linux/actions.c:21:0:
>>
>> /home/travis/build/openvswitch/ovs/datapath/linux/compat/include/linux/skbuff.h:
>> In function ‘rpl_skb_postpull_rcsum’:
>>
>> /home/travis/build/openvswitch/ovs/datapath/linux/compat/include/linux/skbuff.h:384:4:
>> error: implicit declaration of function ‘skb_checksum_start_offset’
>> [-Werror=implicit-function-declaration]
>>
>> cc1: some warnings being treated as errors
>>
>> Reported-by: Joe Stringer <joestringer at nicira.com>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> Is there a reason that we shouldn't backport skb_checksum_start_offset()?
>
The fix is related bug which can occur only on GRO, This function did
exist in kernel which support vxlan gro. but it is probably good to
backport this function. so I will update patch and push it.

> This fixes the compile issue, so if we're happy that this doesn't
> cause a regression on commit a2cf7524787d ("datapath: Backport
> "skbuff: Fix skb checksum flag on skb pull""), then it's fine by me.
>
> Tested-at: https://travis-ci.org/joestringer/openvswitch/jobs/84578330
> Acked-by: Joe Stringer <joestringer at nicira.com>
>
> Separately, have you looked into whether upstream commit 31b33dfb0a14
> ("skbuff: Fix skb checksum partial check.") needs to be backported?

Yes, I am planning on posting the patch.