[ovs-dev] [PATCH] Fix extract_ofp_msgs to use HMAP_NODE_NULL_INITIALIZER instead of hard-coding {0, NULL} while creating _instances[] arrays

Sabyasachi Sengupta Sabyasachi.Sengupta at alcatel-lucent.com
Wed Oct 14 02:34:39 UTC 2015


I agree. Its just that this was the only place where hmap_node is 
initialized without the initializer macro..

---
Nuage Networks Business Unit, Alcatel-Lucent,
755 Ravendale Drive, Mountain View, CA, 94043
Mailstop: 1127, Ph: 1-650-623-3461

On Tue, 13 Oct 2015, Ben Pfaff wrote:

> On Tue, Oct 13, 2015 at 06:38:57PM -0700, Sabyasachi Sengupta wrote:
>>
>>> This change will cause segfaults if anything ever reaches the end of a
>>> bucket.
>>
>> Oh, didn't realize that, but it seems to work fine in my setup. Just
>> wondering how it works while initializing all_raw_instances. I'm curious how
>> would it be different for _instances.
>
> I take it back.  It is harmless, but it doesn't have any benefit.
>



More information about the dev mailing list