[ovs-dev] [PATCH 10/23] patch: Refactor to better support new kinds of patches.

Justin Pettit jpettit at nicira.com
Thu Oct 15 23:38:57 UTC 2015


> On Oct 9, 2015, at 9:15 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> +    /* Add any patch ports that should exist but don't. */
> +    parse_bridge_mappings(ctx, br_int, &existing_ports);

This comment could probably use a bit more information.

> +    /* Delete any patch ports that do exist but shouldn't.  (Any that both
> +     * should and do exist were removed above.) */

I think it might be a bit clearer if you replaced "above" with 'from "existing_ports"' or something similar.

Acked-by: Justin Pettit <jpettit at nicira.com>

--Justin





More information about the dev mailing list