[ovs-dev] [PATCH 11/23] patch: Allow client to determine port names.

Justin Pettit jpettit at nicira.com
Fri Oct 16 00:17:28 UTC 2015


> On Oct 9, 2015, at 9:20 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> -        create_patch_ports(ctx, network, existing_ports, br_int, ovs_bridge);
> -        create_patch_ports(ctx, network, existing_ports, ovs_bridge, br_int);
> +        char *br_int_name = patch_port_name(br_int, ovs_bridge);
> +        char *ovs_bridge_name = patch_port_name(ovs_bridge, br_int);
> +        create_patch_ports(ctx, network,
> +                           br_int, br_int_name,
> +                           ovs_bridge, ovs_bridge_name,
> +                           existing_ports);

Is there a reason to create the patch port names here instead of in create_patch_ports()?  It seems like it complicates the interface for create_patch_ports() for not much benefit.

Acked-by: Justin Pettit <jpettit at nicira.com>

--Justin





More information about the dev mailing list