[ovs-dev] [PATCH 10/23] patch: Refactor to better support new kinds of patches.

Ben Pfaff blp at nicira.com
Fri Oct 16 20:08:17 UTC 2015


On Thu, Oct 15, 2015 at 04:38:57PM -0700, Justin Pettit wrote:
> 
> > On Oct 9, 2015, at 9:15 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > +    /* Add any patch ports that should exist but don't. */
> > +    parse_bridge_mappings(ctx, br_int, &existing_ports);
> 
> This comment could probably use a bit more information.
> 
> > +    /* Delete any patch ports that do exist but shouldn't.  (Any that both
> > +     * should and do exist were removed above.) */
> 
> I think it might be a bit clearer if you replaced "above" with 'from "existing_ports"' or something similar.
> 
> Acked-by: Justin Pettit <jpettit at nicira.com>

Thanks for the review!

I updated the comments to:

    /* Create in the database any patch ports that should exist.  Remove from
     * 'existing_ports' any patch ports that do exist in the database and
     * should be there. */
    parse_bridge_mappings(ctx, br_int, &existing_ports);

    /* Now 'existing_ports' only still contains patch ports that exist in the
     * database but shouldn't.  Delete them from the database. */



More information about the dev mailing list