[ovs-dev] [PATCH 19/23] ovn-nb: Change how router ports work.

Ben Pfaff blp at nicira.com
Fri Oct 16 20:50:18 UTC 2015


On Thu, Oct 15, 2015 at 06:26:54PM -0700, Justin Pettit wrote:
> 
> > On Oct 9, 2015, at 9:20 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Acked-by: Justin Pettit <jpettit at nicira.com>

Thanks.

I realized when looking at this that I didn't put any rationale into the
commit message.  I improved it:

    ovn-nb: Change how router ports work.
    
    This is for two reasons.  First, a router port is not really much of a
    special case from a logical switch's point of view.  For switching
    purposes, it works exactly the same as any other port.  Having a special
    column for it just adds artificial special cases.
    
    Second, the previous form of router ports specified that all of them use
    the logical port name "ROUTER".  This seemed to make sense at the time but
    now it is just adding more special cases.  Instead just giving them names
    like any other port makes life easier.
    
    Signed-off-by: Ben Pfaff <blp at nicira.com>
    Acked-by: Justin Pettit <jpettit at nicira.com>



More information about the dev mailing list