[ovs-dev] [PATCH v2 2/4] ovn: Implement the ability to send a packet back out its input port.

Justin Pettit jpettit at nicira.com
Sun Oct 18 17:58:35 UTC 2015


> On Oct 17, 2015, at 2:07 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> 
> +            if (!port && sf->field->id == MFF_REG6) {

Is there a reason you're using MFF_REG6 instead of MFF_IN_PORT?

> +                sf = ofpact_put_SET_FIELD(ofpacts);
> +                sf->field = mf_from_id(MFF_IN_PORT);
> +                bitwise_put(UINT64_MAX, &sf->mask, sf->field->n_bytes, 0,
> +                            sf->field->n_bits);

Is there a reason to use this instead of bitwise_one(), which seems to have clearer intent?  The code right above doesn't do it either, so I'm just curious if it's not equivalent.

Acked-by: Justin Pettit <jpettit at nicira.com>

--Justin





More information about the dev mailing list