[ovs-dev] [PATCH v2 1/4] physical: Fix implementation of logical patch ports.

Ben Pfaff blp at nicira.com
Sun Oct 18 19:02:49 UTC 2015


On Sun, Oct 18, 2015 at 10:33:11AM -0700, Justin Pettit wrote:
> 
> > On Oct 17, 2015, at 2:07 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > Logical patch ports do not have a physical location and effectively reside
> > on every hypervisor.  This is fine for unicast output to logical patch
> > ports.  However, when a logical patch port is part of a logical multicast
> > group, lumping them together with the other "local" ports in a multicast
> > group yields packet duplication, because every hypervisor to which the
> > packet is tunneled re-outputs it to the logical patch port.
> > 
> > This commit fixes the problem, by treating logical patch ports as remote
> > rather than local when they are part of a logical multicast group.  This
> > yields exactly-once semantics.
> > 
> > Found while testing implementation of ARP in OVN logical router.  The
> > following commit adds a test that fails without this fix.
> 
> It's not actually the following patch, but the one after that.
> 
> Acked-by: Justin Pettit <jpettit at nicira.com>

Oops.

I decided to just flip the order of patches 1 and 2, since they were
independent.

Thanks for the review!



More information about the dev mailing list