[ovs-dev] [PATCH] datapath-windows: fix NULL check in OvsGetExtInfoIoctl()

Gurucharan Shetty shettyg at nicira.com
Wed Oct 21 23:27:54 UTC 2015


On Mon, Oct 19, 2015 at 3:15 PM, Nithin Raju <nithin at vmware.com> wrote:
> End result is that "mac_in_use" column gets populated in
> OVSDB for internal and external NICs.
>
> Signed-off-by: Nithin Raju <nithin at vmware.com>
Applied with the acks.

> ---
>  datapath-windows/ovsext/Vport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
> index baab056..4ade842 100644
> --- a/datapath-windows/ovsext/Vport.c
> +++ b/datapath-windows/ovsext/Vport.c
> @@ -1542,7 +1542,7 @@ OvsGetExtInfoIoctl(POVS_VPORT_GET vportGet,
>      if (vportGet->portNo == 0) {
>          StringCbLengthA(vportGet->name, OVS_MAX_PORT_NAME_LENGTH - 1, &len);
>          vport = OvsFindVportByHvNameA(gOvsSwitchContext, vportGet->name);
> -        if (vport != NULL) {
> +        if (vport == NULL) {
>              /* If the port is not a Hyper-V port and it has been added earlier,
>               * we'll find it in 'ovsPortNameHashArray'. */
>              vport = OvsFindVportByOvsName(gOvsSwitchContext, vportGet->name);
> --
> 1.8.5.6
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list