[ovs-dev] [PATCH] datapath-windows: Report correctly when trying to add tunnel types

Alin Serdean aserdean at cloudbasesolutions.com
Thu Oct 29 06:15:44 UTC 2015


Report invalid parameter to the userspace if the user tries to add a vport
tunnel type which is not supported by the kernel extension.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
---
 datapath-windows/ovsext/Vport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 4ade842..658161d 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
@@ -2188,7 +2188,8 @@ OvsNewVportCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
                 transportPortDest = STT_TCP_PORT;
                 break;
             default:
-                break;
+                nlError = NL_ERROR_INVAL;
+                goto Cleanup;
             }
 
             if (vportAttrs[OVS_VPORT_ATTR_OPTIONS]) {
-- 
1.9.5.msysgit.0



More information about the dev mailing list