[ovs-dev] [PATCH] datapath-windows: Report correctly when trying to add tunnel types

Sairam Venugopal vsairam at vmware.com
Thu Oct 29 18:06:18 UTC 2015


Alin,

Thanks for the patch.

Acked-by: Sairam Venugopal <vsairam at vmware.com>



On 10/28/15, 11:15 PM, "Alin Serdean" <aserdean at cloudbasesolutions.com>
wrote:

>Report invalid parameter to the userspace if the user tries to add a vport
>tunnel type which is not supported by the kernel extension.
>
>Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>---
> datapath-windows/ovsext/Vport.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/datapath-windows/ovsext/Vport.c
>b/datapath-windows/ovsext/Vport.c
>index 4ade842..658161d 100644
>--- a/datapath-windows/ovsext/Vport.c
>+++ b/datapath-windows/ovsext/Vport.c
>@@ -2188,7 +2188,8 @@ OvsNewVportCmdHandler(POVS_USER_PARAMS_CONTEXT
>usrParamsCtx,
>                 transportPortDest = STT_TCP_PORT;
>                 break;
>             default:
>-                break;
>+                nlError = NL_ERROR_INVAL;
>+                goto Cleanup;
>             }
> 
>             if (vportAttrs[OVS_VPORT_ATTR_OPTIONS]) {
>-- 
>1.9.5.msysgit.0
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=5--ztsGVK76YRGzxpO7WqRYVcnqw4v
>iWXlvl9Vadl9U&s=GUoIRAidZRkwAnZxdECyUqfEmV78C7QzBS6l-7ZDAHs&e= 




More information about the dev mailing list