[ovs-dev] [PATCH] datapath-windows: Proper cleanup in case of driver init failure

[Sorin Vinturis]

Nithin,

The documentation for the NdisFRegisterFilterDriver() function states the following:

" Drivers that call NdisFRegisterFilterDriver must be prepared for an immediate call to any of their FilterXxx functions."

So all initialization must be done before calling the above function.

-Sorin

-----Original Message-----
From: Nithin Raju [mailto:nithin at vmware.com] 
Sent: Tuesday, 1 September, 2015 18:27
To: Sorin Vinturis
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Proper cleanup in case of driver init failure

> On Sep 1, 2015, at 8:06 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> 
> Nithin,
> 
> In my tests with Driver Verifier enabled I bumped into a situation when NdisFRegisterFilterDriver() failed. In this case DriverEntry() returned an error, without releasing the spinlocks allocated in OvsInit(), which resulted in a memory leak BSOD triggered by the Driver Verifier. The patch solves this issue.

Can we move the call to OvsInit() to after NdisFRegisterFilterDriver()?

-- Nithin