[ovs-dev] [PATCH v7 2/3] ovn: Automatically create br-int in ovn-controller.
Ben Pfaff
blp at nicira.com
Tue Sep 1 19:27:43 UTC 2015
On Tue, Sep 01, 2015 at 03:09:04PM -0400, Russell Bryant wrote:
> On 09/01/2015 02:29 PM, Ben Pfaff wrote:
> > [This is probably threaded wrong; somehow the patch didn't make it into
> > my inbox and I had to apply it from the archive.]
>
> Weird. I use git-send-email and always give it the message-id of patch
> 0/N of the last revision to reply to.
This is a problem with me or my mailbox, not with your email.
> > It seems that, when create_br_int() creates the integration bridge, it
> > should return it to get_br_int() so that it can return it (instead of
> > NULL).
>
> Fair enough. I remember doing that on purpose, but I'm not positive
> why. Maybe I thought it should be committed before returning it from
> there for some reason. In any case, I'll fix that up.
>
> > Should we add some text to ovn-architecture(7) mentioning that
> > ovn-controller will create the integration bridge? It's still possible
> > that the platform will want to create the integration bridge before
> > starting ovn-controller, if it wants to add vifs to that bridge in
> > advance. So now it becomes optional.
> >
> > I wonder whether ovn-controller(8) should mention this behavior.
>
> These doc suggestions sound good. I'll update ovn-architecture and
> ovn-controller docs.
Great, I'll look forward to v8.
More information about the dev
mailing list