[ovs-dev] [PATCH] datapath-windows: check vport attribute before access
Nithin Raju
nithin at vmware.com
Thu Sep 3 14:01:49 UTC 2015
OVS_VPORT_ATTR_OPTIONS being an optional attribute should be
preceded by a check for valid value before access.
Signed-off-by: Nithin Raju <nithin at vmware.com>
---
datapath-windows/ovsext/Vport.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 6b74ec2..dd615e4 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
@@ -2177,10 +2177,12 @@ OvsNewVportCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
break;
}
- PNL_ATTR attr = NlAttrFindNested(vportAttrs[OVS_VPORT_ATTR_OPTIONS],
- OVS_TUNNEL_ATTR_DST_PORT);
- if (attr) {
- transportPortDest = NlAttrGetU16(attr);
+ if (vportAttrs[OVS_VPORT_ATTR_OPTIONS]) {
+ PNL_ATTR attr = NlAttrFindNested(vportAttrs[OVS_VPORT_ATTR_OPTIONS],
+ OVS_TUNNEL_ATTR_DST_PORT);
+ if (attr) {
+ transportPortDest = NlAttrGetU16(attr);
+ }
}
status = OvsInitTunnelVport(usrParamsCtx,
--
1.8.5.6
More information about the dev
mailing list