[ovs-dev] [PATCH 2/2] ovn-nbctl: Add ACL commands.
Justin Pettit
jpettit at nicira.com
Thu Sep 10 21:07:54 UTC 2015
> On Sep 5, 2015, at 4:53 PM, Ben Pfaff <blp at nicira.com> wrote:
>
> - printf("%10s %5ld (%s) %s%s\n", acl->direction, acl->priority,
> + printf("%10s %5"PRId64" (%s) %s%s\n", acl->direction, acl->priority,
Fixed.
> I'd prefer to avoid casts in acl_cmp(), also the macro there doesn't
> seem to help much:
This is better. Thanks.
> + if (dir1 != dir2) {
> + return dir1 > dir2 ? -1 : 1;
I changed this to "<", so that it would sort from smallest to largest, which means "from-lport" comes before "to-lport".
> Acked-by: Ben Pfaff <blp at nicira.com>
Thanks. Assuming you agree with the above change, I'll keep this ack.
--Justin
More information about the dev
mailing list