[ovs-dev] [Patch V10] ovn-controller-vtep: Add vtep module.

ALeX Wang ee07b291 at gmail.com
Tue Sep 15 06:40:30 UTC 2015


Thx for the review,

Applied to master~,

On 14 September 2015 at 16:12, Justin Pettit <jpettit at nicira.com> wrote:

>
> > On Sep 13, 2015, at 1:58 PM, Alex Wang <ee07b291 at gmail.com> wrote:
> >
> > --- a/ovn/controller-vtep/gateway.c
> > +++ b/ovn/controller-vtep/gateway.c
> > @@ -189,7 +189,8 @@ gateway_run(struct controller_vtep_ctx *ctx)
> > }
> >
> > /* Destroys the chassis table entries for vtep physical switches.
> > - * Returns true when all done. */
> > + * Returns true when done (i.e. there is no change made to 'ovnsb_idl'),
> > + * otherwise returns false. */
>
> My only comment is that I'd use "ctx->ovnsb_idl".  I think it's ready to
> merge.
>
> Acked-by: Justin Pettit <jpettit at nicira.com>
>
> --Justin
>
>
>


-- 
Alex Wang,
Open vSwitch developer



More information about the dev mailing list