[ovs-dev] [v3 02/10] configure: add configuration options for libcap-ng

Ben Pfaff blp at nicira.com
Fri Sep 18 19:12:34 UTC 2015


On Mon, Sep 14, 2015 at 03:54:06PM -0700, Andy Zhou wrote:
> Add configuration option for enabling or disabling linking with
> libcap-ng.  This option is enabled by default. Disabling this option
> prevents ovs-vswitchd from accepting the --user option on Linux.
> 
> Signed-off-by: Andy Zhou <azhou at nicira.com>

This should probably update the installation guide to note the new
optional library dependency.

Since capabilities are a security feature, like SSL, I think that we
should handle libcapng like we do OpenSSL, e.g.:

        - no option: use libcapng if it's present

        - --disable-libcapng: do not use libcapng

        - --enable-libcapng: do use libcapng and fail configuration if
          it's missing

See OVS_CHECK_OPENSSL for the details.

Please add m4 quoting here:
       AC_CHECK_LIB(cap-ng, capng_clear, HAVE_LIBCAPNG=yes)
e.g.:
       AC_CHECK_LIB([cap-ng], [capng_clear], [HAVE_LIBCAPNG=yes])

Thanks,

Ben.



More information about the dev mailing list