[ovs-dev] [PATCH] ofproto/bond: simplify rebalancing logic

Ben Pfaff blp at nicira.com
Fri Sep 18 21:56:19 UTC 2015


On Tue, Sep 15, 2015 at 02:09:59PM -0700, Andy Zhou wrote:
> The current bond relancing logic is more complicated than necessary.
> When considering a bucket for rebalancing, we just need to make sure
> post rebalancing traffic will be closer to the ideal traffic split
> than before. This patch implements the simplification.
> 
> There is a bug is current algorithm that causes a heavyly loaded bucket
> to ping-pong for each reblancing interval. The simplied loigc also fixes
> this bug.
> 
> Though not the main motivation for the change, computations are now
> done with integer math rather than floating math.
> 
> Reported-by: Gregory Smith <gasmith at nutanix.com>
> Signed-off-by: Andy Zhou <azhou at nicira.com>

It seems reasonable at first glance, but I wonder whether you went
through the history of this logic to make sure that we're not regressing
on any of the improvements we've made over time?

If you think so, then
Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list