[ovs-dev] [v3 01/10] lib/daemon: add function to switch daemon user at run time

Andy Zhou azhou at nicira.com
Fri Sep 18 23:02:22 UTC 2015


On Fri, Sep 18, 2015 at 12:17 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Sep 17, 2015 at 10:05:22PM -0700, Ansis Atteka wrote:
>> > +static inline void
>> > +daemon_become_new_user(void)
>> > +{
>> > +    /* Not implemented. */
>> I think Ben had a comment that on Windows we should not silently
>> ignore such errors. However, let me review rest of the patches.
>
> I think my comment was at least partly wrong, because this function will
> get called unconditionally, whether switching to a new user has been
> requested or not.  So let me modify my previous comment to say that, if
> the user requests switching to a new user, then on Windows OVS should
> either not recognize the option at all or fail in
> daemon_become_new_user().  I guess the latter is probably more
> user-friendly because the former would just leave the user puzzled about
> why the option was in the manual but not implemented.

I agree, Fail on Windows is more user-friendly unless we can
conditionally include
man page sections.  It can also serve as place holder for future enhancements.



More information about the dev mailing list