[ovs-dev] [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

[Joe Stringer]

On 25 September 2015 at 05:10, Thomas F Herbert
<thomasfherbert at gmail.com> wrote:
> On 9/24/15 7:43 PM, Pravin Shelar wrote:
>>
>> On Thu, Sep 24, 2015 at 11:25 AM, Thomas F Herbert
>> <thomasfherbert at gmail.com> wrote:
>>>
>>> Pravin,
>>>
>>> I am you hoping you can take a look at a potential problem with my kernel
>>> module patch submitted to net-dev today. I decided to submit it anyway
>>> because that is the best way to get eyes on it.
>>>
>>> I am still seeing a problem where the 4 conntrak attributes show up in an
>>> upcall when a double tagged packet is received. The attribute lengths for
>>> the 4 unknown attributes should be -1 but are showing up as odd lengths.
>>> I
>>> can't see where my patch below is causing this problem but I don't see
>>> similar errors with missed upcall in either single tagged or untagged
>>> packets. I have applied my companion patch to the user space for 802.1ad
>>> so
>>> the problem could be in that patch with de-serializing "unknown"
>>> attributes.
>>>
>>> Also, this may not be a problem at all because the kernel module includes
>>> the conntrak patches but the user space does not as yet.
>>>
>>> I am running ovs commit ca92d173 with my user space 802.1ad patch.
>>>
>>> The error message is below:
>>>
>>> Sep 24 14:01:34 Centos7Bld ovs-vswitchd[2666]:
>>> recirc_id(0),dp_hash(0),skb_priority(0),in_port(3),skb_mark(0),key22(bad
>>> key
>>> length 1, expected -1)(00),key23(bad key length 2, expected -1)(00
>>> 00),key24(bad key length 4, expected -1)(00 00 00 00),key25(bad key
>>> length
>>> 16, expected -1)(00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>>> 00),eth(src=52:f6:ef:24:b6:4e,dst=08:00:27:7f:8f:e1),eth_type(0x88a8),
>>>
>>> vlan(vid=100,pcp=0),encap(eth_type(0x8100),vlan(vid=999,pcp=0),encap(eth_type(0x0800),
>>>
>>> ipv4(src=192.168.1.3,dst=192.168.1.2,proto=1,tos=0,ttl=64,frag=no),icmp(type=0,code=0)))
>>>
>>
>> I am not sure. can you send me github link to user-space patch, so
>> that I can check.
>
> Pravin,
>
> OK, also I noticed that the user space patch for conntrak was submitted on
> 9/17. I think I will try to rebase user space patch on top of conntrak patch
> and re-test after fixing issues in kernel patch.
>
> Thanks,

Thomas,

It looks like a mismatch between your kernel module headers and
userspace headers. The conntrack changes upstream introduce four new
KEY_ATTRs, but those haven't been backported to the userspace yet. So,
if you add new KEY_ATTR numbers in
$OVS_GIT/datapath/linux/compat/include/linux/openvswitch.h, then they
may conflict with the numbers that the kernel uses in
$LINUX_GIT/include/uapi/linux/openvswich. The kernel version is the
source of truth for these.

You're right, there was patches submitted for this recently and I'm
actively working on trying to get those integrated into the OVS tree.