[ovs-dev] [PATCH 1/3] ofp-actions: Look inside write_actions for output ports and groups.

Ben Pfaff blp at nicira.com
Tue Sep 29 23:34:14 UTC 2015


On Fri, Sep 18, 2015 at 02:02:40PM -0600, gavin_remaley at selinc.com wrote:
> This patch looks good, though it looks like the general issue with 
> examining the Actions within a Write Actions instruction has several 
> instances beyond what is addressed by this patch.
> 
> I have noticed that an invalid Group ID within Write Actions is not caught 
> (Flow is programmed with no error).  That appears to be a problem in 
> ofproto.c -> ofproto_check_ofpacts.  A similar fix seemed to address that 
> issue.
> 
> I did a global search for OFPACT_FOR_EACH and examined the action 
> processing.  I see several other potential problems with Write Actions.
> 
> ofp-actions.c -> ofpacts_check
> ofp-actions.c -> ofpacts_get_meter
> ofproto.c -> ofproto_check_ofpacts
> 
> Thanks for your help.

You're right, I missed those.

I sent an improved series here:
        http://openvswitch.org/pipermail/dev/2015-September/060624.html



More information about the dev mailing list