[ovs-dev] [PATCH] Correct Netronome Vendor Id

Simon Horman simon.horman at netronome.com
Wed Sep 30 06:36:39 UTC 2015


On Tue, Sep 29, 2015 at 10:57:50PM -0700, Ben Pfaff wrote:
> On Wed, Sep 30, 2015 at 11:52:58AM +0900, Simon Horman wrote:
> > Due to an error on my part the Netronome vendor Id is incorrect:
> > the last digit should be 'D' rather than '0' as per the
> > Netronome IEEE OUI.
> 
> Huh.  I guess the difference between Nortel and Netronome is 13.

Yes, it seems so.

> > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> > 
> > ---
> > 
> > * Compile tested only
> > 
> > * This problem is also present in branch-2.4
> > 
> > * Regarding backwards compatibility.
> > 
> >   My understanding is that the Netronome Vendor Id is only used by the
> >   NTR (Netronome) selection method extension and that feature is not widely
> >   used.  Thus I have skipped on making this change backwards compatible.
> > 
> >   If backwards compatibility is desired I believe it can
> >   be achieved by having parse_ofp15_group_prop_exp() accept
> >   both the correct new and incorrect old value.
> 
> It looks really easy to add that, would you mind taking care of it?

Sure, will do.



More information about the dev mailing list