[ovs-dev] [PATCH_v5 08/26] Misc cleanup with "util.h" header files

Ben Warren ben at skyportsystems.com
Fri Apr 1 02:45:35 UTC 2016


> On Mar 30, 2016, at 4:33 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Fri, Mar 25, 2016 at 02:10:27PM -0700, ben at skyportsystems.com wrote:
>> From: Ben Warren <ben at skyportsystems.com>
>> 
>> Removed from redundant #includes and moved some macros to different file
>> scope
>> 
>> Signed-off-by: Ben Warren <ben at skyportsystems.com>
>> Acked-by: Ryan Moats <rmoats at us.ibm.com>
> 
> With this applied I get pervasive warnings like this:
> 
>    /usr/lib/gcc/i586-linux-gnu/4.9//include/stdarg.h:51:9: warning: preprocessor token va_copy redefined
>    ../lib/util.h:33:9: this was the original definition
> 
> I think that probably this is due to defining va_copy before #including
> <stdarg.h>, but I haven't looked.
> 
> I feel like it's a good idea to let the changes that I've already
> applied percolate through everyone's build systems, etc. for a while, so
> I'm going to leave off with this series for now.  When you've had a
> chance to look at this problem, please post a v6.

Hmmm, I get a clean build with this patch applied.  I notice you’re using GCC 4.9, while mine is a bit older:

ben at ben-lab-sc:~/workspace/ovs$ gcc --version
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

ben at ben-lab-sc:~/workspace/ovs$ libtool --version
libtool (GNU libtool) 2.4.2


What distro, toolchain versions and Make targets do you recommend for testing prior to patch submission?  I’ll spin up the appropriate VM so this is not an issue.

regards,
Ben


More information about the dev mailing list