[ovs-dev] [PATCH] Configure or disable ovn-controller probe timer on the fly

Ben Pfaff blp at ovn.org
Fri Apr 1 15:53:52 UTC 2016


On Thu, Mar 31, 2016 at 03:00:59PM -0700, nghosh at us.ibm.com wrote:
>     Configure or disable ovn-controller probe_timer on the fly.
>     
>     There are four sessions established from ovn-controller to the following:
>     OVN Southbound — jsonrpc based
>     Local vswitchd — jsonrpc based
>     Local vswitchd — openflow based from ofctrl
>     Local vswitchd — openflow based from pinctrl
>     
>     All of these sessions have their own probe_interval, and currently only one
>     [SB] of them can be configured using ovn-vsctl command, and even that is not
>     effective on the fly —in other words, ovn-controller has to be restarted to
>     use that probe_timer value.

There's no value in configuring the other ones.  First, they're all
connections to local processes so there's little or no cost.  Second,
there's probes are unnecessary for Unix domain sockets, because the
kernel will notify us immediately if the connection is dropped.  JSONRPC
sessions automatically disable probing for Unix domain sockets (see
jsonrpc_session_open()).  I thought that our OpenFlow connections did
the same thing, but the code isn't there.  Probably, a better patch to
submit would be one to do that.

Thanks,

Ben.



More information about the dev mailing list