[ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

[Ryan Moats]

Russell Bryant <russell at ovn.org> wrote on 04/11/2016 08:40:34 AM:

> From: Russell Bryant <russell at ovn.org>
> To: Na Zhu <nazhu at cn.ibm.com>
> Cc: ovs dev <dev at openvswitch.org>, Ryan Moats/Omaha/IBM at IBMUS
> Date: 04/11/2016 08:41 AM
> Subject: Re: [PATCH v3 1/1] ovn: Add column enabled to table
Logical_Router
>
> On Mon, Apr 11, 2016 at 12:47 AM, Na Zhu <nazhu at cn.ibm.com> wrote:
> This patch add column "enabled" to table Logical_Router
> for setting router administrative state.
>
> The type of "enabled" is bool.
>
> If the administrative state is false, delete all the flows
> relevant to the logical router from table Logical_Flow.
>
> Signed-off-by: Na Zhu <nazhu at cn.ibm.com>
>
> I'm unable to apply this patch.  It looks to be because it was sent
> using your IBM mail client.  Can you try sending with "git send-
> email" instead?
>
> Thanks,
>
> --
> Russell Bryant

Russell beat me to my first point.

Second, I'm still not convinced as to whether this is the best way to
go about this.  While it should work, it is adding/removing multiple
flows as a logical router scales horizontally.  Instead, could we just
add/remove a single high priority drop flow for the router so that we
are only manipulating a single flow?

Ryan Moats (regXboi)