[ovs-dev] [ovs-dev,v13,2/8] Persist lport and mcgroup indexes

Ben Pfaff blp at ovn.org
Mon Apr 11 23:28:53 UTC 2016


On Thu, Mar 31, 2016 at 10:05:06AM -0500, Ryan Moats wrote:
> From: RYAN D. MOATS <rmoats at us.ibm.com>
> 
> Persisting these entries is a pre-requisite for incremental
> processing.
> 
> Signed-off-by: RYAN D. MOATS <rmoats at us.ibm.com>

I get lots of new errors here:

../ovn/controller/lport.c:48:39: error: passing 'const struct hmap_node *' to parameter of type 'struct hmap_node *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
../lib/hmap.h:259:50: note: passing argument to parameter 'node' here
../ovn/controller/lport.c:49:38: error: passing 'const struct hmap_node *' to parameter of type 'struct hmap_node *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
../lib/hmap.h:259:50: note: passing argument to parameter 'node' here
../ovn/controller/lport.c:50:39: error: passing 'const struct hmap_node *' to parameter of type 'struct hmap_node *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
../lib/hmap.h:259:50: note: passing argument to parameter 'node' here
../ovn/controller/lport.c:51:14: error: passing 'const struct lport *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
/usr/include/stdlib.h:483:25: note: passing argument to parameter '__ptr' here
../ovn/controller/lport.c:179:44: error: passing 'const struct hmap_node *' to parameter of type 'struct hmap_node *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
../lib/hmap.h:259:50: note: passing argument to parameter 'node' here
../ovn/controller/lport.c:180:41: error: passing 'const struct hmap_node *' to parameter of type 'struct hmap_node *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
../lib/hmap.h:259:50: note: passing argument to parameter 'node' here
../ovn/controller/lport.c:181:14: error: passing 'const struct mcgroup *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
/usr/include/stdlib.h:483:25: note: passing argument to parameter '__ptr' here

Other than that my thoughts are pretty much the same as for patch 1.

Thanks!



More information about the dev mailing list