[ovs-dev] [ovs-dev, v13, 3/8] Persist local_datapaths and patched_datapaths

[Ben Pfaff]

On Thu, Mar 31, 2016 at 10:05:07AM -0500, Ryan Moats wrote:
> From: RYAN D. MOATS <rmoats at us.ibm.com>
> 
> Persist local_datapaths and patch_datapaths across runs so
> that changes to either can be used as a trigger to reset
> incremental flow processing.
> 
> Signed-off-by: RYAN D. MOATS <rmoats at us.ibm.com>

New compiler errors:

    ../ovn/controller/binding.c:132:12: error: incompatible pointer types returning 'struct hmap_node *' from a function with result type 'struct local_datapath *' [-Werror,-Wincompatible-pointer-types]
    ../ovn/controller/binding.c:142:9: error: implicit declaration of function 'reset_flow_processing' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

Also sparse points out several global variables that should probably be
static:

../ovn/controller/binding.c:126:13: warning: symbol 'local_datapaths_by_uuid' was not declared. Should it be static?
../ovn/controller/ovn-controller.c:227:20: warning: symbol 'lports' was not declared. Should it be static?
../ovn/controller/ovn-controller.c:228:22: warning: symbol 'mcgroups' was not declared. Should it be static?
../ovn/controller/ovn-controller.c:232:13: warning: symbol 'local_datapaths' was not declared. Should it be static?
../ovn/controller/ovn-controller.c:233:13: warning: symbol 'patched_datapaths' was not declared. Should it be static?
../ovn/controller/ofctrl.c:109:13: warning: symbol 'match_flow_table' was not declared. Should it be static?
../ovn/controller/ofctrl.c:110:13: warning: symbol 'uuid_flow_table' was not declared. Should it be static?
../ovn/controller/physical.c:147:13: warning: symbol 'hc_uuid' was not declared. Should it be static?